Skip to content

Conversation

juliohm
Copy link
Member

@juliohm juliohm commented Oct 3, 2025

Allow types in Map transform to enable convenient pipelines like

using TableTransforms
using Colors

ColorView(color=RGB; low=0.02, high=0.98) = LowHigh(; low, high)  Map(color)

@juliohm juliohm requested review from Copilot and eliascarv October 3, 2025 12:55
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the Map transform to accept types in addition to functions, enabling more convenient pipeline patterns with type constructors. The changes allow passing types directly to the transform, which will be called as constructors on the selected columns.

  • Extended Map constructor to accept types alongside functions as callable arguments
  • Updated type definitions to support Union{Function,Type} instead of just Function
  • Added comprehensive test coverage for the new type-based functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/transforms/map.jl Core implementation adding type support through updated type aliases and extraction logic
test/transforms/map.jl Test cases covering type constructors with and without target names
test/shows.jl Updated display tests to reflect new Union{Function, Type} signature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.33%. Comparing base (ccd0a29) to head (72c7415).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          50       50           
  Lines        1440     1442    +2     
=======================================
+ Hits         1416     1418    +2     
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliohm juliohm merged commit c97af6f into master Oct 3, 2025
8 checks passed
@juliohm juliohm deleted the more-map-args branch October 3, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants