Skip to content

Add missing support to StdFeats transform #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

Add missing support to StdFeats transform #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/transforms/stdfeats.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ isrevertible(::Type{StdFeats}) = true
_stdfun(x) = _stdfun(elscitype(x), x)
_stdfun(::Type, x) = identity, identity
function _stdfun(::Type{Continuous}, x)
μ = mean(x)
σ = std(x, mean=μ)
μ = mean(skipmissing(x))
σ = std(skipmissing(x), mean=μ)
stdfun = x -> zscore(x, μ, σ)
revfun = y -> revzscore(y, μ, σ)
stdfun, revfun
Expand Down
10 changes: 10 additions & 0 deletions test/transforms/stdfeats.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,14 @@
@test tₒ.c == t.c
@test tₒ.d ≈ t.d
@test tₒ.e == t.e

# missing values
a = [rand(1:10, 99); missing]
b = [rand(Normal(7, 10), 99); missing]
t = Table(; a, b)
T = StdFeats()
n, c = apply(T, t)
@test isequal(n.a, t.a)
@test isapprox(mean(skipmissing(n.b)), 0; atol=1e-6)
@test isapprox(std(skipmissing(n.b)), 1; atol=1e-6)
end
Loading