Skip to content

Conversation

@github-actions
Copy link
Contributor

This pull request changes the compat entry for the SIMDPirates package from 0.2, 0.3, 0.5, 0.6.3, 0.7 to 0.2, 0.3, 0.5, 0.6.3, 0.7, 0.8.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@chriselrod
Copy link
Contributor

Any thoughts on this:

condition number: Test Failed at /Users/travis/build/JuliaMath/AccurateArithmetic.jl/test/runtests.jl:43

  Expression: c / 100 < c_ < 1000c

   Evaluated: 1.0e18 < 1.8002797962063685e23 < 1.0e23

Stacktrace:

?

@ffevotte
Copy link
Contributor

This is related to random number generations: sometimes the randomly generated vector does not have the expected condition number. This happens from time to time, although I'm not sure why, since it is my understanding that @testset deterministically sets the pRNG seed. I suspect this to have something to do with some characteristic of some test nodes, that would make them generate a slightly different sequence of random numbers. But I've never looked into this in too many details.

In any case, this has nothing to do with SIMDPirates, so it should be safe to bump the compat entry.

@ffevotte ffevotte merged commit 974593c into master May 25, 2020
@ffevotte ffevotte deleted the compathelper/new_version/2020-05-25-00-13-18-142-4013004090 branch May 25, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants