Error in The Quotient Rule #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differentiation of a fraction is wrong if the numerator or denominator independent of the variable differentiated with respect to. It looks like somebody forgot to divide by (denominator)^2 for the special cases where one of the derivatives is 0
Collaborator
|
Awesome work. Could you add a few tests for this so that it won't break in the future? |
Collaborator
Author
|
Then there is at least a 3 tests for the tree possible code paths in The Quotient Rule differentiation. They are harder to write than they should be because the isequal() function matches exact expressions without canonicalisation. A more relaxed matching that at least accept commutative functions (*, +), might be useful, but would of course introduce another layer of complexity that has to be tested at the same time. |
Collaborator
Author
|
Anything holding you back from merging this pull request? |
johnmyleswhite
added a commit
that referenced
this pull request
Jul 24, 2013
Error in The Quotient Rule
Collaborator
|
Nope, this looks good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differentiation of a fraction is wrong if the numerator or denominator independent of the variable differentiated with respect to.
It looks like somebody forgot to divide by (denominator)^2 for the special cases where one of the derivatives is 0