[Rootfs] Add keyword argument to exclude old ABIs from output of expand_* functions
#446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keeping the old ABIs with a flag, seems like a good idea to me, just in case we need to rebuild something old for a security fix. |
|
I agree, we can just add a kwarg like |
|
IMO, we should kill armv6, armv7 and ppc altogether - mainly because those binaries are never getting used. Freebsd arm64 also seems like one that shouldn't be built by default. The only one that we don't actually use is riscv (in that there are no julia binaries), but that feels like one to retain since it is an up and coming architecture. Having a way to build the old ones feels reasonable. |
This was [announced](https://discourse.julialang.org/t/psa-intent-to-deprecate-cxx03-libgfortran3-libgfortran4-abis/130799) a few months ago and no one reacted, this implements the suggested changes.
giordano
changed the title
expand_* functionsexpand_* functions
|
@Keno @staticfloat are you happy with this? |
staticfloat
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was announced a few months ago and no one reacted, this implements the suggested changes.
My only question is: do we want to retain the ability for these functions to include the old ABIs with some extra keyword argument, or we simply forget about them (users will still be able to manually create those platforms)? This PR does the latter. If we want the former, what's the suggested keyword argument?