Specify that JuliaDict / JuliaSet it is a MutableMapping/Set #692
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm good spot. However before I go documenting this slightly incorrect behaviour I wonder if it would be better to have both Could use ArrayInterface.jl for this. |
|
Actually what I've said is a separate issue. Merged with thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked against the source code in
https://github.com/JuliaPy/PythonCall.jl/blob/92bef8ab44cb4bb4f915e6bf3b2ec4f51405852e/src/JlWrap/set.jl#L122C17-L122C27
and
PythonCall.jl/src/JlWrap/dict.jl
Line 110 in 92bef8a