Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised that
GeometryTypes.Vec
is used for points instead ofGeometryTypes.Point
(also in the GJK implementation in GeometryTypes). I'd like to at least also supportPoint
, sinceVec
is meant to be used for free vectors (e.g. displacements) instead of bound vectors, as far as I understand.I was doubting whether to make this change in GeometryTypes or here, but I feel like here is more appropriate, as
GeometryTypes.support_vector_max
also returns a score, which is unused in this package and is just wasted computation (unless the compiler is able to optimize that away). In general, I feel like we should maybe stop relying onGeometryTypes.support_vector_max
for this reason.