Skip to content

Conversation

@chriselrod
Copy link
Member

@chriselrod chriselrod commented Jan 23, 2022

This implements a breaking change.
It is now the called functions responsibility to set the state pointer to SPIN once it is done running.

@chriselrod chriselrod enabled auto-merge January 23, 2022 21:21
@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #38 (39f2932) into master (dfdcc02) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          122       128    +6     
=========================================
+ Hits           122       128    +6     
Impacted Files Coverage Δ
src/ThreadingUtilities.jl 100.00% <100.00%> (ø)
src/threadtasks.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfdcc02...39f2932. Read the comment docs.

@chriselrod
Copy link
Member Author

Two failures remain:

  1. MacOS nightly getting wrong answers
  2. Windows allocating, except for 32 bit nightly Julia

@chriselrod chriselrod merged commit 716d26f into master Feb 17, 2022
@chriselrod chriselrod deleted the sleep_all_tasks branch February 17, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants