Skip to content

Conversation

@geoffroyleconte
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #21 (86086b8) into master (26c136e) will increase coverage by 0.06%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   97.99%   98.05%   +0.06%     
==========================================
  Files           6        6              
  Lines         598      617      +19     
==========================================
+ Hits          586      605      +19     
  Misses         12       12              
Impacted Files Coverage Δ
src/feasibility-form-nls.jl 99.55% <83.33%> (+<0.01%) ⬆️
src/feasibility-residual.jl 100.00% <100.00%> (ø)
src/quasi-newton.jl 93.33% <100.00%> (ø)
src/slack-model.jl 96.66% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26c136e...86086b8. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsTest.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thansk. Just a small modification for now.

@lencheck nls.nls_meta.nequ Jv
prod = @closure v -> jprod_residual!(nls, x, v, Jv)
ctprod = @closure v -> jtprod_residual!(nls, x, v, Jtv)
prod! = @closure (res, v, α, β) -> begin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests like these and these

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsTest.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsTest.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsTest.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsTest.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

@abelsiqueira abelsiqueira changed the title Update compat LinearOperators 2 and NLPModels 0.17 Bump to LinearOperators 2 and NLPModels 0.17 Jul 2, 2021
@abelsiqueira abelsiqueira merged commit 7cdca7d into JuliaSmoothOptimizers:master Jul 2, 2021
@abelsiqueira
Copy link
Member

Thanks

@geoffroyleconte geoffroyleconte deleted the linop2 branch July 2, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants