Skip to content

Conversation

@tmigot
Copy link
Member

@tmigot tmigot commented Jul 30, 2021

This was already done in FeasibilityFormNLS.

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #26 (82d2770) into main (37af6fd) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   98.05%   98.03%   -0.02%     
==========================================
  Files           6        6              
  Lines         617      611       -6     
==========================================
- Hits          605      599       -6     
  Misses         12       12              
Impacted Files Coverage Δ
src/feasibility-residual.jl 100.00% <ø> (ø)
src/slack-model.jl 96.66% <ø> (ø)
src/quasi-newton.jl 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37af6fd...82d2770. Read the comment docs.

@abelsiqueira
Copy link
Member

Any idea on what's up with Cirrus?

@github-actions
Copy link
Contributor

Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsTest.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

@tmigot
Copy link
Member Author

tmigot commented Jul 30, 2021

Any idea on what's up with Cirrus?

Checking the previous PRs, the error appears when we changed master to main, but not sure what to do with it.

@tmigot
Copy link
Member Author

tmigot commented Jul 30, 2021

'AmplNLReader.jl' fails because I actually need this PR and another one to fix it after the new 'NLPModelMeta'.

For 'JSOSolvers', there is a conflict with the Krylov.solve! function.

@abelsiqueira abelsiqueira merged commit 516d633 into JuliaSmoothOptimizers:main Jul 30, 2021
@abelsiqueira
Copy link
Member

Thanks.

@tmigot tmigot deleted the parametric-nlp branch July 30, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants