Add linear API in FeasibilityFormNLS #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 95.40% 96.26% +0.86%
==========================================
Files 6 6
Lines 761 804 +43
==========================================
+ Hits 726 774 +48
+ Misses 35 30 -5
Continue to review full report at Codecov.
|
|
|
|
I realized there were some tests missing for the linear API, and then some issues in the current implementation. Since, it is quite a large PR here is a recap':
|
|
The breaking packages are the one, where the linear API is not implemented. |
This was referenced Jun 3, 2022
|
abelsiqueira
approved these changes
Jun 6, 2022
add linear example and fixes add counters debug slack encapsulate in a function
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in JuliaSmoothOptimizers/NLPModelsKnitro.jl#88