Remove SlackModel increment!

[tmigot]

This is another bug, SlackModel do not have counters so increment!(nlp, :neval_cons_lin) will count another one for nlp.model.

[codecov]

Codecov Report

Merging #67 (d597065) into main (a10ec90) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   96.26%   96.23%   -0.04%     
==========================================
  Files           6        6              
  Lines         804      796       -8     
==========================================
- Hits          774      766       -8     
  Misses         30       30              

Impacted Files	Coverage Δ
src/slack-model.jl	93.18% <ø> (-0.14%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dpo]

Isn't that what we want though?

[tmigot]

cons_lin(nlp::SlackModel, x) already calls cons_lin(nlp.model, x) (which increments the counters), so there is no need to have the increment! in cons_lin(nlp::SlackModel, x) as well.

[dpo]

Ah I see! Thank you.

[github-actions]

Package name	latest	stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsTest.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl