Skip to content

Conversation

@tmigot
Copy link
Member

@tmigot tmigot commented Jun 5, 2021

Follows NLPModels.jl PR #353 with parametric meta.

Should be merged after NLPModelsModifiers.jl PR #12.

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again.
I think that we'll need specialized constructors as well. Not sure, because it depends on how and what we test with other packages. In particular, multi-precision tests. Otherwise, we can simply say

mutable struct SomeProblem <: AbstractNLPModel{Float64, Vector{Float64}}

@amontoison
Copy link
Member

Thanks Tangi ! I will update NLPModelsJuMP after this PR.

@tmigot
Copy link
Member Author

tmigot commented Jun 7, 2021

Thanks again.
I think that we'll need specialized constructors as well. Not sure, because it depends on how and what we test with other packages. In particular, multi-precision tests. Otherwise, we can simply say

mutable struct SomeProblem <: AbstractNLPModel{Float64, Vector{Float64}}

I added specialized constructors, just because it is more general this way. In case, we add further mutli-precision tests as you mentioned.

@tmigot tmigot force-pushed the meta-parametric branch from d1df4d6 to 0927c1b Compare June 11, 2021 13:11
@github-actions
Copy link
Contributor

Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #11 (6949c6c) into master (97dedb0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   98.62%   98.63%           
=======================================
  Files          24       24           
  Lines        2109     2120   +11     
=======================================
+ Hits         2080     2091   +11     
  Misses         29       29           
Impacted Files Coverage Δ
src/nlp/problems/brownden.jl 100.00% <100.00%> (ø)
src/nlp/problems/hs10.jl 100.00% <100.00%> (ø)
src/nlp/problems/hs11.jl 100.00% <100.00%> (ø)
src/nlp/problems/hs14.jl 100.00% <100.00%> (ø)
src/nlp/problems/hs5.jl 100.00% <100.00%> (ø)
src/nlp/problems/hs6.jl 100.00% <100.00%> (ø)
src/nlp/problems/lincon.jl 100.00% <100.00%> (ø)
src/nlp/problems/linsv.jl 100.00% <100.00%> (ø)
src/nlp/problems/mgh01feas.jl 100.00% <100.00%> (ø)
src/nls/problems/lls.jl 82.20% <100.00%> (+0.15%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97dedb0...6949c6c. Read the comment docs.

@tmigot tmigot marked this pull request as ready for review June 11, 2021 14:46
Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@abelsiqueira abelsiqueira merged commit 553bf84 into JuliaSmoothOptimizers:master Jun 11, 2021
@tmigot tmigot deleted the meta-parametric branch June 11, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants