-
Couldn't load subscription status.
- Fork 3
Parametric NLPModelMeta #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametric NLPModelMeta #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again.
I think that we'll need specialized constructors as well. Not sure, because it depends on how and what we test with other packages. In particular, multi-precision tests. Otherwise, we can simply say
mutable struct SomeProblem <: AbstractNLPModel{Float64, Vector{Float64}}
|
Thanks Tangi ! I will update |
I added specialized constructors, just because it is more general this way. In case, we add further mutli-precision tests as you mentioned. |
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=======================================
Coverage 98.62% 98.63%
=======================================
Files 24 24
Lines 2109 2120 +11
=======================================
+ Hits 2080 2091 +11
Misses 29 29
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Follows NLPModels.jl PR #353 with parametric meta.
Should be merged after NLPModelsModifiers.jl PR #12.