Skip to content

Conversation

@nalimilan
Copy link
Contributor

Some functions were documented as applying only to matrices but they actually work for vectors too.

Some functions were documented as applying only to matrices but they actually
work for vectors too.
@nalimilan
Copy link
Contributor Author

BTW I've noticed that in the manual the docstring for findnz documenting the vector method is missing, despite being listed in index.md. Any ideas?
https://docs.julialang.org/en/v1.12-dev/stdlib/SparseArrays/#SparseArrays.findnz

@codecov
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.10%. Comparing base (4fd3aad) to head (c2e11f0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   84.07%   84.10%   +0.02%     
==========================================
  Files          12       12              
  Lines        9188     9189       +1     
==========================================
+ Hits         7725     7728       +3     
+ Misses       1463     1461       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Member

Probably just an oversight.

@nalimilan
Copy link
Contributor Author

Thanks. Anybody willing to merge? I don't have the permissions.

@dkarrasch dkarrasch merged commit c575811 into JuliaSparse:main Jan 6, 2025
10 checks passed
@nalimilan nalimilan deleted the nl/docs branch January 6, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants