Skip to content

Add a no-op PValue(::PValue) constructor #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Add a no-op PValue(::PValue) constructor #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0310c3
Add a no-op PValue(::PValue) constructor
ararslan Oct 22, 2020
239e913
Extra =s for that fresh, egal taste
ararslan Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/statmodels.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,7 @@ struct PValue
new(v)
end
end
PValue(p::PValue) = p

function show(io::IO, pv::PValue)
v = pv.v
Expand Down
16 changes: 9 additions & 7 deletions test/statmodels.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using StatsBase
using StatsBase: PValue
using Test, Random

v1 = [1.45666, -23.14, 1.56734e-13]
Expand Down Expand Up @@ -28,16 +29,17 @@ m = rand(3,4)
[3] 0.344454 0.179574 0.242208 0.4531
──────────────────────────────────────────"""

@test sprint(show, StatsBase.PValue(1.0)) == "1.0000"
@test sprint(show, StatsBase.PValue(1e-1)) == "0.1000"
@test sprint(show, PValue(1.0)) == "1.0000"
@test sprint(show, PValue(1e-1)) == "0.1000"
if VERSION > v"1.6.0-DEV"
@test sprint(show, StatsBase.PValue(1e-5)) == "<1e-04"
@test sprint(show, PValue(1e-5)) == "<1e-04"
else
@test sprint(show, StatsBase.PValue(1e-5)) == "<1e-4"
@test sprint(show, PValue(1e-5)) == "<1e-4"
end
@test sprint(show, StatsBase.PValue(NaN)) == "NaN"
@test_throws ErrorException StatsBase.PValue(-0.1)
@test_throws ErrorException StatsBase.PValue(1.1)
@test sprint(show, PValue(NaN)) == "NaN"
@test_throws ErrorException PValue(-0.1)
@test_throws ErrorException PValue(1.1)
@test PValue(PValue(0.05)) === PValue(0.05)

@test sprint(showerror, ConvergenceException(10)) == "failure to converge after 10 iterations."

Expand Down