Fix sdp bad constraint handling #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
src/SDPoptimize.jl
Outdated
| (next_state[i]>=model.xlim[i][1])&& | ||
| (next_state[i]<=model.xlim[i][2])) | ||
| end | ||
|
|
There was a problem hiding this comment.
Could you DRY this pattern (as you use it more than once)?
There was a problem hiding this comment.
I will put it in SDPutils ok
Current coverage is 93.85% (diff: 100%)
@@ dev-nightly #111 diff @@
=============================================
Files 10 10
Lines 676 683 +7
Methods 0 0
Messages 0 0
Branches 0 0
=============================================
+ Hits 634 641 +7
Misses 42 42
Partials 0 0
|
|
Ok to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the way constraints are handled in SDP.
It is not necessary anymore to add the state constraints to the constraints function.
This PR should be merged quickly as the previous implementation will create issues in problem instances with constraints mixing states and controls