Release v0.1.1 #65
Merged
Release v0.1.1 #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frapac
commented
May 1, 2016
frapac
commented
- improve sphinx documentation
- improve coverage of unit-tests
- fix some messy code in SDDPoptimize.jl
- add cuts pruning
- remove deprecated code and examples
Add cuts pruning to SDDP
Update sphinx documentation
+ remove deprecated error in SDDPoptimize + remove deprecated function in noise.jl + update backward pass
Improve coverage of unit-testing
Current coverage is 91.36%
@@ master #65 diff @@
========================================
Files 8 8
Lines 638 648 +10
Methods 0 0
Branches 0 0
========================================
+ Hits 545 592 +47
+ Misses 93 56 -37
Partials 0 0
|
|
|
||
| Install a linear programming solver | ||
| ----------------------------------- | ||
|
|
There was a problem hiding this comment.
If Clp is installed by the Pkg.clone above we should state it.
doc/quickstart.rst
Outdated
|
|
||
| and we consider the following initial position:: | ||
|
|
||
| X0 = [50, 50] |
There was a problem hiding this comment.
Explain why there is two values ?
| :code:`costsddp` returns the value of costs along each scenario, and :code:`stocks` the evolution of each stock along time. | ||
|
|
||
| .. _JuMP: http://jump.readthedocs.io/en/latest/installation.html#coin-or-clp-and-cbc | ||
|
|
There was a problem hiding this comment.
Finish with a plot of the trajectories, and an estimation of the gap given by the strategy.
| Polyhedral functions where cuts will be removed | ||
| """ | ||
| function prune_cuts!(model::SPModel, params::SDDPparameters, V::Vector{PolyhedralFunction}) |
There was a problem hiding this comment.
"exact_prune_cuts!" would be more precise
|
Great work ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.