Add docstring for runtests
#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
commented
Oct 8, 2025
Comment on lines
223
to
231
| ## Behavior | ||
| - Automatically discovers all `.jl` files in the test directory (excluding `setup.jl` and `runtests.jl`) | ||
| - Sorts tests by file size (largest first) for optimal load balancing | ||
| - Launches worker processes with appropriate Julia flags for testing | ||
| - Monitors memory usage and recycles workers that exceed memory limits | ||
| - Provides real-time progress output with timing and memory statistics | ||
| - Handles interruptions gracefully (Ctrl+C) | ||
| - Returns nothing, but throws `Test.FallbackTestSetException` if any tests fail |
There was a problem hiding this comment.
I don't know if this is too much information, but I think it's cool to know what it does.
vchuravy
reviewed
Oct 8, 2025
vchuravy
reviewed
Oct 8, 2025
vchuravy
reviewed
Oct 8, 2025
vchuravy
reviewed
Oct 8, 2025
| - Automatically discovers all `.jl` files in the test directory (excluding `setup.jl` and `runtests.jl`) | ||
| - Sorts tests by file size (largest first) for optimal load balancing | ||
| - Launches worker processes with appropriate Julia flags for testing | ||
| - Monitors memory usage and recycles workers that exceed memory limits |
There was a problem hiding this comment.
We should use the environment flag from Julia Base here
There was a problem hiding this comment.
Uhm, this is a suggestion about the implementation, not the docstring, right?
vchuravy
reviewed
Oct 8, 2025
Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly written by Cursor, with a revision by me.