Move default number of jobs to its own function #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Oct 9, 2025
src/ParallelTestRunner.jl
Outdated
| --verbose Print more information during testing. | ||
| --quickfail Fail the entire run as soon as a single test errored. | ||
| --jobs=N Launch `N` processes to perform tests (default: Sys.CPU_THREADS). | ||
| --jobs=N Launch `N` processes to perform tests (default: $(default_njobs())). |
There was a problem hiding this comment.
Is it useful to print it here? It looks at free_memory and thus can change
There was a problem hiding this comment.
Ah, yes, can also remove the default value, it's just that Sys.CPU_THREADS is definitely wrong.
There was a problem hiding this comment.
Ok, I removed the printing of the default value entirely, for simplicity.
|
The estimated memory use probably also needs to become configurable, as well as some additional flexibility to pick |
giordano
force-pushed
the
mg/default-njobs
branch
from
b8fbcf1 to
a6759f2
Compare
maleadt
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, print the actual default number of jobs in the help messsage, instead of referring to
Sys.CPU_THREADSwhich is inaccurate.