Skip to content

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Oct 17, 2025

Fixes #32

@christiangnrd
Copy link
Contributor

christiangnrd commented Oct 17, 2025

No new macro is definitely better! How does the WorkerTestSet not get propagated to the rest of the testsets?

Edit: It does :/

Running 2 tests in parallel. If this is too many, specify the `--jobs=N` argument to the tests, or set the `JULIA_CPU_THREADS` environment variable.
               │          │ ──────────────── CPU ──────────────── │
Test  (Worker) │ Time (s) │ GC (s) │ GC % │ Alloc (MB) │ RSS (MB) │
mps/size   (2) │     0.620.010.966.50580.78 │
mtl/size   (1) │     0.640.010.967.05579.80 │

Test Summary: | Error  Total  Time
  Overall     |     2      2  7.4s
    mps/size  |     1      1  6.2s
    mtl/size  |     1      1  6.5s
    FAILURE

Error in testset mps/size:
Error During Test at /Users/christian/.julia/dev/ParallelTestRunner/src/ParallelTestRunner.jl:255
  Got exception outside of a @test
  LoadError: AssertionError: Test.get_testset_depth() == 0

@christiangnrd
Copy link
Contributor

I am still missing the "failed at" print, but that should be a relatively straightforward scan over the results.

You should take my compat_anynonpass stuff from #54 (and rename it to something better if possible 🙂). It works well and gets rid of these ugly two lines:

if (VERSION >= v"1.13.0-DEV.1037" && !Test.anynonpass(o_ts)) ||
(VERSION < v"1.13.0-DEV.1037" && !o_ts.anynonpass)

christiangnrd added a commit to christiangnrd/ParallelTestRunner.jl that referenced this pull request Oct 17, 2025
@vchuravy
Copy link
Member Author

Urgh, propagating the custom Testset is an understandable, yet annoying move.

@vchuravy
Copy link
Member Author

@christiangnrd we have now converged to something very similar :)

Okay, if I merge this, and can I add you as a co-author to the merge commit?

@vchuravy vchuravy requested a review from maleadt October 17, 2025 13:02
@giordano
Copy link
Collaborator

Can add a test for the stacktrace?

@maleadt maleadt self-assigned this Oct 17, 2025
@christiangnrd
Copy link
Contributor

@christiangnrd we have now converged to something very similar :)

Okay, if I merge this, and can I add you as a co-author to the merge commit?

That works for me

@maleadt maleadt removed their assignment Oct 17, 2025
Copy link
Collaborator

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Co-authored-by: Christian Guinard <28689358+christiangnrd@users.noreply.github.com>
Co-authored-by: Christian Guinard <28689358+christiangnrd@users.noreply.github.com>
@vchuravy vchuravy merged commit dc61eec into main Oct 17, 2025
20 checks passed
@vchuravy vchuravy deleted the vc/worker_ts branch October 17, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retain precise testset information in failed tests

4 participants