Revert multithreaded connect pattern #1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under heavy loads, the introduction of spawned tasks to handle connecting can be bad when the scheduler is now switching between lots of tasks and the delay can interact poorly with proxies.
quinnj
force-pushed
the
jq-revert-connect
branch
from
e1482b3 to
d7a6a85
Compare
Codecov Report
@@ Coverage Diff @@
## master #1078 +/- ##
==========================================
- Coverage 82.41% 82.33% -0.08%
==========================================
Files 32 32
Lines 3048 3040 -8
==========================================
- Hits 2512 2503 -9
- Misses 536 537 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under heavy loads, the introduction of spawned tasks to handle connecting can be bad when the scheduler is now switching between lots of tasks and the delay can interact poorly with proxies.