Add version property to X509Request. Various test fixes. Update CI.
#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
commented
May 20, 2025
| x509_server_cert = OpenSSL.get_peer_certificate(ssl) | ||
|
|
||
| @test String(x509_server_cert.issuer_name) == "/C=US/O=Let's Encrypt/CN=R3" | ||
| @test String(x509_server_cert.issuer_name) == "/C=US/O=Let's Encrypt/CN=R11" |
Member
Author
There was a problem hiding this comment.
@quinnj @staticfloat Does this fix look correct/reasonable?
Member
Author
There was a problem hiding this comment.
IanButterworth
changed the title
IanButterworth
force-pushed
the
ib/update_ci
branch
from
6fe59f4 to
506ebeb
Compare
IanButterworth
force-pushed
the
ib/update_ci
branch
from
19b76a6 to
a301372
Compare
IanButterworth
force-pushed
the
ib/update_ci
branch
from
a301372 to
ad1ef7f
Compare
IanButterworth
changed the title
IanButterworth
changed the title
version property to X509Request. Various test fixes. Update CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.