Skip to content

Conversation

@simensen
Copy link
Contributor

@simensen simensen commented Oct 5, 2021

I'm getting Psalm warnings about the facade not being set up correctly:

Scanning files...
Exception: Target class [feature-flags] does not exist.
Skipping \JustSteveKing\Laravel\FeatureFlags\FeatureFlagsFacade.
Exception: Target class [feature-flags] does not exist.
Skipping \JustSteveKing\Laravel\FeatureFlags\FeatureFlagsFacade.
...

Since it's not actually configured, and at least at this point I can't think of how we'd actually use a facade without actually writing a proper facade or service class, I think it's best to just remove it.

@JustSteveKing
Copy link
Owner

@simensen we will also need to remove this from the project composer.json file so Laravel doesn't fart when trying to alias something in the container that doesn't exist

@simensen
Copy link
Contributor Author

simensen commented Oct 6, 2021

@JustSteveKing Nice catch. I could have sworn there was another place that this was configured and couldn't find it. :) I figured it would just get auto-discovered somehow by scanning directories. sigh

In any event, hopefully, it is all good now. :)

@JustSteveKing
Copy link
Owner

These things slip through sometimes!

@JustSteveKing JustSteveKing merged commit e7c8af1 into JustSteveKing:main Oct 6, 2021
@JustSteveKing
Copy link
Owner

This has now been released as 0.1.0

@simensen simensen deleted the remove-facade branch October 6, 2021 16:41
@simensen
Copy link
Contributor Author

simensen commented Oct 6, 2021

@JustSteveKing Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants