Laravel 12.x Compatibility #31
Conversation
|
|
|
⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch. To do so, temporarily add Shift's fork to the {
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/laravel-feature-flags.git"
}
]
}Then update your dependency constraint to reference this branch: {
"require": {
"juststeveking/laravel-feature-flags": "dev-l12-compatibility",
}
}Finally, run: |
WalkthroughThe changes update the CI test workflow and dependency constraints. The GitHub Actions workflow now tests against Laravel version 12, in addition to versions 10 and 11, with corresponding adjustments to include and exclude rules. In parallel, the Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant PHP as PHP Runtime
Dev->>GH: Push commit with updated workflow & dependencies
GH->>PHP: Retrieve test matrix (Laravel 10.*, 11.*, 12.*)
GH->>PHP: Execute tests (excludes PHP 8.1 for Laravel 11 & 12)
PHP-->>GH: Return test results
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (10)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hey, @JustSteveKing 👋 I hope you're having an awesome day! First and foremost, I'd like to express my gratitude for the existence of this package and the work and love you've poured into it! Apparently, you no longer advocate for the use of this package and instead suggest using Laravel Pennant. The fact that a first-party Laravel package exists for this use case is superb. However, there is one crucial bit missing in Laravel Pennant: per-user/group basis activation of a particular feature by an administrator. You see, Laravel Pennant is supposed to be automated, and unfortunately, there is no easy and straightforward way to get it to work in this manner. We have spent numerous days to get Pennant to work this way, but ultimately it was all futile. On the contrary, this use case was a breeze to implement with your package, and as such, it would be highly appreciated if you could add Laravel 12 support! Please let me know if you need additional help to get it merged. Thanks! 🙏 |
|
Hey @mabdullahsari Not a problem! I will look to get this into a mergeable state, it's usually test bench versioning that makes Laravel 12 PRs fail atm, so will start there |
3 participants
This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 12.x.
Before merging, you need to:
l12-compatibilitybranchIf you do find an issue, please report it by commenting on this PR to help improve future automation.
Summary by CodeRabbit
New Features
Chores