Template method pattern #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afmachin
reviewed
Oct 3, 2025
| public final void order(String addition) { | ||
| boilWater(); | ||
| createDrink(); | ||
| serveDrink(); |
There was a problem hiding this comment.
AM-1: The hook method should be on the base class. The subclasses can implement "helper" private methods, but not other public methods.
|
|
||
| userDrink.boilWater(); | ||
| userDrink.createDrink(); | ||
| userDrink.serveDrink(); |
There was a problem hiding this comment.
AM-2: You should only be calling the order method. Without it you are not enforcing the pattern.
| userDrink.serveDrink(); | ||
|
|
||
| if (userChoice.equalsIgnoreCase("coffee")) { | ||
| System.out.println("Would you like milk and sugar with your coffee (y/n)?"); |
There was a problem hiding this comment.
AM-1.5: The code inside here should be the hook method, and in the base class you default it to false. As this is now the Drinks are not using the template method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.