finished draft #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afmachin
reviewed
Sep 28, 2025
| } | ||
|
|
||
| public void on() { | ||
| setting = (setting + 1) % 4; |
There was a problem hiding this comment.
AM-1: Great use of the modulo, easy to read and slim code!
| public interface Command { | ||
| void execute(); | ||
|
|
||
| void undo(); |
| public class TV { | ||
| String name = "TV"; | ||
|
|
||
| public TV(String name) { |
There was a problem hiding this comment.
AM-3: There is nothing wrong with this (especially since I had it written like this in the assignment), but I noticed something when was looking at the import in the Client class. Since the word TV only has two letters, TV looks like it should be a constant, since all letters are capitalized. To fix this our class names should be longer ie: Television.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.