first draft state #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afmachin
reviewed
Oct 19, 2025
| this.count += count; | ||
| System.out.println("The gumball machine was just refilled; its new count is: " + this.count); | ||
| if (currentState == soldOutState) { | ||
| currentState = noQuarterState; |
There was a problem hiding this comment.
AM-1(F): This should be calling the setState method.
| //State Interface | ||
| //Should showcase actions on the state only | ||
| public interface GumballMachineState { | ||
| void insertQuarter(); |
| return winnerState; | ||
| } | ||
|
|
||
| public void refill(int count) { |
There was a problem hiding this comment.
AM-3(F): (No points removed): This is technically a change in state therefore the states should implement this method, but it breaks SOLID, since we are forcing the concretes to implement something they often cant define. There is no good answer, I just wanted to point it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.