Skip to content

perf!: move depth computation from visualizer to tree builder #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 28, 2025
Merged

perf!: move depth computation from visualizer to tree builder #281

merged 10 commits into from
Jun 28, 2025

Conversation

@KSXGitHub
Copy link
Owner

@KSXGitHub KSXGitHub commented Jun 28, 2025 •
edited
Loading

Breaking Changes

  • TreeBuilder and FsTreeBuilder now asks for max_depth.
  • Visualizer::max_depth has been removed.
  • The types of some max_depth fields have been changed from NonZeroUsize to NonZeroU64.

Related: #277

@github-actions
Copy link

github-actions bot commented Jun 28, 2025 •
edited
Loading

Performance Regression Reports

commit: 9be7505

There are no regressions.

@KSXGitHub KSXGitHub mentioned this pull request Jun 28, 2025
Open
@KSXGitHub KSXGitHub changed the title feat(api)!: move depth computation from visualizer to tree builder perf!: move depth computation from visualizer to tree builder Jun 28, 2025
@KSXGitHub KSXGitHub marked this pull request as ready for review June 28, 2025 17:48
@KSXGitHub KSXGitHub merged commit 4c7cbb4 into master Jun 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KSXGitHub