Skip to content

Conversation

@falric
Copy link
Contributor

@falric falric commented Mar 28, 2024

Hopefully the JSDoc, README, and test will give a decent idea of what’s been added.

The screenshots are from an draft version of node-web, KTH/node-web#115.

Screen.Recording.2024-03-28.at.13.04.41.mov
Screen.Recording.2024-03-28.at.13.05.01.mov
Screen.Recording.2024-03-28.at.13.05.16.mov

@falric falric requested a review from a team March 28, 2024 12:08
@ahrsjo
Copy link

ahrsjo commented Apr 2, 2024

A general question, perhaps out of scope.

Is the preferred language stored somehow for each user (localStorage, navigator.language property or something else)?

@falric
Copy link
Contributor Author

falric commented Apr 2, 2024

A general question, perhaps out of scope.

Is the preferred language stored somehow for each user (localStorage, navigator.language property or something else)?

In a 🍪

@nsandstrom
Copy link
Contributor

Maybe not related to this particular PR, but in what pattern do we use "label" when it comes to translation? it seems like 25% something of all keywords is prefixed "label_", but I am not sure if there is a pattern.

@falric
Copy link
Contributor Author

falric commented Apr 3, 2024

Maybe not related to this particular PR, but in what pattern do we use "label" when it comes to translation? it seems like 25% something of all keywords is prefixed "label_", but I am not sure if there is a pattern.

Ah. Yes. Naming conventions for ”message keys”. I would use label to mean ”Short text that describes an element or group of elements”. Element in this case doesn’t need to be an actual DOM Element, or even the specific label element. That said, we don’t have a convention and we should have one.

@falric falric merged commit e072b77 into main Apr 3, 2024
@falric falric deleted the feat/language-link-helper branch April 3, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants