Fix language error, add tests for it and refactor the init method #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrsjo
reviewed
Apr 29, 2024
nsandstrom
reviewed
Apr 29, 2024
ahrsjo
reviewed
Apr 30, 2024
falric
added a commit
that referenced
this pull request
May 8, 2024
commit 6d80189 Merge: 4746946 a7f04a3 Author: Rickard Falk <959319+falric@users.noreply.github.com> Date: Wed May 8 08:44:25 2024 +0200 Merge pull request #57 from KTH/fix/language-error Fix language error, add tests for it and refactor the init method commit a7f04a3 Author: Pipeline <pipeline@kth.se> Date: Thu May 2 12:09:48 2024 +0000 9.3.1-0 commit cf61720 Author: Rickard Falk <ricf@kth.se> Date: Thu May 2 14:03:39 2024 +0200 refactor language tests commit da2a120 Author: Rickard Falk <ricf@kth.se> Date: Thu May 2 14:03:10 2024 +0200 fix: set res.locals.locale.language commit 6be3590 Author: Rickard Falk <ricf@kth.se> Date: Tue Apr 30 10:24:51 2024 +0200 add tests for res.locals.locale.language commit 9078fe5 Author: Rickard Falk <ricf@kth.se> Date: Tue Apr 30 08:43:53 2024 +0200 fix: accept-language header contains preferred languages, not a single language commit d46d132 Author: Ellen <ellen.widerstrand@gmail.com> Date: Mon Apr 29 15:42:22 2024 +0200 Refactor init method for language commit 8f96edc Author: Ellen <ellen.widerstrand@gmail.com> Date: Mon Apr 29 15:41:57 2024 +0200 Add some more tests commit e08ce20 Author: mthege <martinathege@gmail.com> Date: Mon Apr 29 14:55:38 2024 +0200 feat: tests for language.js commit 3d5dd4d Author: Rickard Falk <ricf@kth.se> Date: Mon Apr 29 13:34:03 2024 +0200 fix: use chosenLocale for cookie language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.