Skip to content

Fix papermill #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2021
Merged

Fix papermill #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b69b8c
Fix python installation; and test papermill is installed in python
Philmod Jun 21, 2021
d58d59c
Put conda at the end of the path to use the default python first; als…
Philmod Jun 21, 2021
8f09f8b
Remove conda from path
Philmod Jun 21, 2021
205b62c
Install pip for python3.8
Philmod Jun 22, 2021
7dad439
Remove container after running it
Philmod Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,10 @@ FROM gcr.io/kaggle-images/rcran:${BASE_TAG}

ADD clean-layer.sh /tmp/clean-layer.sh

# Default to python3.7
RUN apt-get update && \
update-alternatives --install /usr/bin/python python /usr/bin/python3.8 1 && \
update-alternatives --config python && \
apt install -y python3-pip python3-venv && \
/tmp/clean-layer.sh
# Default to python3.8
RUN ln -sf /usr/bin/python3.8 /usr/bin/python
RUN curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
RUN python get-pip.py

RUN apt-get update && \
apt-get install apt-transport-https && \
Expand All @@ -36,7 +34,7 @@ RUN apt-get install -y libhdf5-dev && \
/tmp/clean-layer.sh

RUN apt-get install -y libzmq3-dev default-jdk && \
apt-get install -y python-dev libcurl4-openssl-dev libssl-dev && \
apt-get install -y python3.8-dev libcurl4-openssl-dev libssl-dev && \
pip install jupyter pycurl && \
# Install older tornado - https://github.com/jupyter/notebook/issues/4437
pip install "tornado<6" && \
Expand Down
4 changes: 4 additions & 0 deletions test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ docker run -d --name=jupyter_test_r --read-only --net=none \
sleep 3
docker kill jupyter_test_r && docker rm jupyter_test_r

# Check that papermill is installed in python (b/191304257).
docker run --rm --name=papermill_test_r --read-only --net=none \
"$IMAGE_TAG" python -c 'import sys;import papermill as pm; print(pm.__version__)'

docker run --rm -t --net=none \
-e HOME=/tmp \
-v $PWD:/input:ro -v /tmp/rstats-build/working:/working \
Expand Down