Skip to content

Conversation

@erdalsivri
Copy link
Contributor

No description provided.

@erdalsivri erdalsivri requested a review from jplotts October 28, 2025 15:06
@jplotts
Copy link
Contributor

jplotts commented Oct 28, 2025

I'm assuming your change is probably correct. But it should be reviewed by someone who can confirm which copy we intend to keep.

@jplotts jplotts requested a review from stevemessick October 28, 2025 15:15
@erdalsivri
Copy link
Contributor Author

I'm assuming your change is probably correct. But it should be reviewed by someone who can confirm which copy we intend to keep.

All the imports are kagglesdk so I assume kagglesdk is the one we want to keep but yes safer to wait for Steve's input

Copy link
Contributor

@stevemessick stevemessick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Moving too fast. I always mv kagglesdk ksdk before I update to the latest, so I can check that the diff makes sense. I caught a problem or two doing that, so I'll continue. I must've forgot to delete ksdk. Sorry for the churn.

@erdalsivri
Copy link
Contributor Author

Oops! Moving too fast. I always mv kagglesdk ksdk before I update to the latest, so I can check that the diff makes sense. I caught a problem or two doing that, so I'll continue. I must've forgot to delete ksdk. Sorry for the churn.

No worries at all!

@erdalsivri erdalsivri merged commit 5343896 into main Oct 28, 2025
4 checks passed
@erdalsivri erdalsivri deleted the remove-ksdk branch October 28, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants