remove zipping #105
Merged
remove zipping #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into remove_zipping
…into remove_zipping
…into remove_zipping
rosbo
requested changes
Apr 24, 2024
rosbo
reviewed
Apr 24, 2024
Contributor
rosbo
left a comment
rosbo
left a comment
There was a problem hiding this comment.
Make sure to resolve the conflicts first and then re-request a review from me. Thanks
Contributor
Author
I think you are looking at a different pr? |
rosbo
requested changes
Apr 25, 2024
rosbo
reviewed
Apr 25, 2024
rosbo
reviewed
Apr 25, 2024
rosbo
reviewed
Apr 25, 2024
rosbo
approved these changes
Apr 25, 2024
Contributor
rosbo
left a comment
rosbo
left a comment
There was a problem hiding this comment.
LGTM once the linter issue is fixed:
src/kagglehub/models_helpers.py:45:40: Q000 [*] Single quotes found but double quotes preferred
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr removes zipping before upload and instead passes the structure of a directory to the API directory
Fixes #103