0.7, 2024/03/22 -- LINUX: (Really) Fixed position and size for GNOME (by using GTK_EXTENTS)

Author: Kalmat

AUTHORS.txt

@@ -2,3 +2,6 @@ PyWinBox authors, contributors and maintainers:
 
 Kalmat https://github.com/Kalmat
 elraymond (https://github.com/elraymond)
+Leonard Bruns https://github.com/roym899
+lappely - https://github.com/poipoiPIO
+

CHANGES.txt

@@ -1,3 +1,6 @@
+0.7, 2024/03/22 -- LINUX: (Really) Fixed position and size for GNOME (by using GTK_EXTENTS)
+0.6, 2023/10/12 -- LINUX: Improved position and size for GNOME (by using GTK_EXTENTS)
+                   WIN32: Fixed GetAwarenessFromDpiAwarenessContext not supported on Windows Server
 0.5, 2023/09/06 -- MACOS: Tested OK in multi-monitor setup
 0.4, 2023/08/25 -- Reorganized to avoid IDEs showing external and / or private elements
 0.3, 2023/08/21 -- Linux: Improved window geometry (thanks to elraymond - https://github.com/elraymond)

dist/PyWinBox-0.7-py3-none-any.whl

@@ -62,9 +62,8 @@
         'Programming Language :: Python',
         'Programming Language :: Python :: 3',
         'Programming Language :: Python :: 3 :: Only',
-        'Programming Language :: Python :: 3.7',
-        'Programming Language :: Python :: 3.8',
         'Programming Language :: Python :: 3.9',
-        'Programming Language :: Python :: 3.10'
+        'Programming Language :: Python :: 3.10',
+        'Programming Language :: Python :: 3.11'
     ],
 )

setup.py

@@ -5,7 +5,7 @@
     "version", "PyWinBox", "Box", "Rect", "Point", "Size", "pointInBox"
 ]
 
-__version__ = "0.6"
+__version__ = "0.7"
 
 
 def version(numberOnly: bool = True) -> str:

src/pywinbox/__init__.py

@@ -2,14 +2,16 @@
 # -*- coding: utf-8 -*-
 from __future__ import annotations
 
+import os
 import sys
 assert sys.platform == "linux"
 
 from typing import Union, Optional
 
 from Xlib.xobject.drawable import Window as XWindow
+
 from ._main import Box
-from ewmhlib import EwmhWindow
+from .ewmhlib import EwmhWindow
 
 
 def _getHandle(handle: Union[int, XWindow]) -> Optional[EwmhWindow]:
@@ -26,12 +28,44 @@ def _getWindowBox(handle: EwmhWindow) -> Box:
     # https://stackoverflow.com/questions/12775136/get-window-position-and-size-in-python-with-xlib
     geom = handle.xWindow.get_geometry()
     pos = handle.root.translate_coords(handle.id, 0, 0)
-    return Box(pos.x, pos.y, geom.width, geom.height)
+    x = pos.x
+    y = pos.y
+    w = geom.width
+    h = geom.height
+    # Thanks to roym899 (https://github.com/roym899) for his HELP!!!!
+    if os.environ.get('XDG_SESSION_TYPE', "").lower() == "gnome":
+        # Most apps in GNOME do not set _NET_EXTENTS, but _GTK_EXTENTS,
+        # which is the additional space AROUND the window.
+        _gtk_extents = handle._getGtkFrameExtents()
+        if _gtk_extents and len(_gtk_extents) >= 4:
+            # this means there is a GTK HeaderBar
+            x += int(_gtk_extents[0])
+            y += int(_gtk_extents[2])
+            w -= (int(_gtk_extents[0]) + int(_gtk_extents[1]))
+            h -= (int(_gtk_extents[2]) + int(_gtk_extents[3]))
+    # If not in GNOME: best guess is to trust pos and geom from above
+    # NOTE: if you have this case and are not getting the expected result,
+    #       please open an issue: https://github.com/Kalmat/PyWinBox/issues/new
+    return Box(x, y, w, h)
 
 
 def _moveResizeWindow(handle: EwmhWindow, newBox: Box):
     newLeft = max(0, newBox.left)  # Xlib won't accept negative positions
     newTop = max(0, newBox.top)
-    handle.setMoveResize(x=newLeft, y=newTop, width=newBox.width, height=newBox.height, userAction=True)
-    # handle.configure(x=newLeft, y=newTop, width=newBox.width, height=newBox.height)
-
+    newWidth = newBox.width
+    newHeight = newBox.height
+    if os.environ.get('XDG_SESSION_TYPE', "").lower() == "gnome":
+        # Most apps in GNOME do not set _NET_EXTENTS, but _GTK_EXTENTS,
+        # which is the additional space AROUND the window.
+        _gtk_extents = handle._getGtkFrameExtents()
+        if _gtk_extents and len(_gtk_extents) >= 4:
+            # this means there is a GTK HeaderBar
+            newLeft -= int(_gtk_extents[0])
+            newTop -= int(_gtk_extents[2])
+            newWidth += (int(_gtk_extents[0]) + int(_gtk_extents[1]))
+            newHeight += (int(_gtk_extents[2]) + int(_gtk_extents[3]))
+    # If not in GNOME: best guess is to trust pos and geom from above
+    # NOTE: if you have this case and are not getting the expected result,
+    #       please open an issue: https://github.com/Kalmat/PyWinBox/issues/new
+    handle.setMoveResize(x=newLeft, y=newTop, width=newWidth, height=newHeight, userAction=True)
+    # handle.configure(x=newLeft, y=newTop, width=newWidth, height=newHeight)

src/pywinbox/_pywinbox_linux.py

@@ -134,7 +134,7 @@ def _CGmoveResizeTo(appName: str, title: str, newBox: Box):
     proc = subprocess.Popen(['osascript', '-', appName, title,
                              str(newBox.left), str(newBox.top), str(newBox.width), str(newBox.height)],
                             stdin=subprocess.PIPE, stdout=subprocess.PIPE, encoding='utf8')
-    ret, err = proc.communicate(cmd)
+    _, _ = proc.communicate(cmd)
 
 
 def _flipTop(window: AppKit.NSWindow, box: Box) -> int:

src/pywinbox/_pywinbox_macos.py

@@ -14,13 +14,15 @@
 from ._main import Box
 
 
+# Thanks to poipoiPIO (https://github.com/poipoiPIO) for his HELP!!!
 try:
     dpiAware = ctypes.windll.user32.GetAwarenessFromDpiAwarenessContext(ctypes.windll.user32.GetThreadDpiAwarenessContext())
 except AttributeError:  # Windows server does not implement GetAwarenessFromDpiAwarenessContext
     dpiAware = 0
 
 if dpiAware == 0:
-    ctypes.windll.shcore.SetProcessDpiAwareness(2)
+    # It seems that this can't be invoked twice. Setting it to 1 for apps having 0 (unaware) may have less impact
+    ctypes.windll.shcore.SetProcessDpiAwareness(1)
 
 
 def _getHandle(handle: Union[int, str]) -> Optional[int]: