Img_processing: Refactor drawing logic-Each class now draws its own o… #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChedvaErblich
requested changes
Oct 8, 2024
Collaborator
ChedvaErblich
left a comment
ChedvaErblich
left a comment
There was a problem hiding this comment.
A few comments:
- you should base your commit on the SHOW_FRAMES flag that will be added soon to main
- Please make sure not to write commit titles that are too long.
The title should be short, and if there is additional content, it should be placed in the body of the message.
There should be a blank line between the title and the body, otherwise, everything will be included as the title. - Please have someone else review the code, and after she approves it, I'll push it in.
- Removed singleton from Distance class - Enhanced Velocity to support null values - Suppressed speed calculations and alerts when insufficient distance data is available
MeravBenLulu
force-pushed
the
img_processing/order-drawing
branch
from
ab493b7 to
1a6f5e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.