Fixes #19927 - Drop and readd rules when importing filters

This is a change to the way we handle filter rules. Basically, there is
no way to ensure uniqueness among filter rules so updating rules isn't
possible. The package filter rule has a unique check but it simply
checks ALL fields to see if the rule exists already. This doesn't really
allow for matching though since any field change would constitute a new
rule. Since we're importing/updating filters and not rules, I think
dropping the rules and recreating them is the best way to handle
updates.

Author: David Davis

lib/hammer_cli_csv/content_view_filters.rb

@@ -106,12 +106,15 @@ def create_filters_from_csv(line)
             })
           end
 
-          existing_rules = {}
+          # drop existing rules
           @api.resource(:content_view_filter_rules).call(:index, {
               'per_page' => 999999,
               'content_view_filter_id' => filter_id
           })['results'].each do |rule|
-            existing_rules[rule['name']] = rule
+            @api.resource(:content_view_filter_rules).call(:destroy, {
+                'content_view_filter_id' => filter_id,
+                'id' =>  rule['id']
+            })
           end
 
           collect_column(line[RULES]) do |rule|
@@ -138,16 +141,8 @@ def create_filters_from_csv(line)
               raise "Unknown type '#{type}' from '#{line[RULES]}'"
             end
 
-            rule = existing_rules[name]
-            if !rule
-              print "." if option_verbose?
-              rule = @api.resource(:content_view_filter_rules).call(:create, params)
-              existing_rules[rule['name']] = rule
-            else
-              print "." if option_verbose?
-              params['id'] = rule['id']
-              @api.resource(:content_view_filter_rules).call(:update, params)
-            end
+            print "." if option_verbose?
+            @api.resource(:content_view_filter_rules).call(:create, params)
           end
 
           puts 'done' if option_verbose?

test/csv_test_helper.rb

@@ -130,6 +130,23 @@ def content_view_delete(name)
   end
 end
 
+def content_view_filter_delete(org, cv, name)
+  id = nil
+  stdout,stderr = capture {
+    hammer.run(%W(content-view filter list --search name=#{name} --content-view #{cv} --organization #{org}))
+  }
+  lines = stdout.split("\n")
+  if lines.length == 5
+    id = lines[3].split(" ")[0]
+  end
+
+  if id
+    stdout,stderr = capture {
+      hammer.run(%W(content-view filter delete --id #{id}))
+    }
+  end
+end
+
 require File.join(File.dirname(__FILE__), 'apipie_resource_mock')
 require File.join(File.dirname(__FILE__), 'helpers/command')
 require File.join(File.dirname(__FILE__), 'helpers/resource_disabled')