remove cgi, which seems to be causing problems #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Kattis#162 cgi.escape() would cause "<" to become "<", which would then get rendered by plasTeX as "&lt;". Removing cgi.escape() fixes the issue. One other change rolled into this commit is a necessary change to listingsutf8.py to read input files properly.
pehrsoderman
reviewed
Jan 4, 2020
I.e. do not use any escaping for python3/plastex2
Also, use io.open with encoding=utf-8 rather than using decode('utf-8')
Contributor
Author
|
Commit 2ccd713 differentiates between python2 and python3 (as a proxy for the version of plasTeX, which does not seem to advertise its version as far as I can see). For py2, we retain the use of |
Contributor
Author
|
Commit e94d3a6 fixes an unrelated bug I found; python3 does not have the |
Contributor
Author
|
Merging as these changes are essential for running properly under python3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #162
cgi.escape() would cause "<" to become "
<", which would then getrendered by plasTeX as "
&lt;". Removing cgi.escape() fixes theissue.
One other change rolled into this commit is a necessary change to
listingsutf8.py to read input files properly.