Skip to content

Implement API versioning for service mode based on queue enabling #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Release 17.1.13
merged 1 commit into from
Aug 25, 2025
Merged

Implement API versioning for service mode based on queue enabling #1562

merged 1 commit into from
Aug 25, 2025

Conversation

@amangalampalli-ks
Copy link
Contributor

Implement API versioning for service mode based on queue enabling

API Versioning Implementation

  • Added dual API support based on queue_enabled configuration:

    • /api/v2/ - Queue enabled (default): Asynchronous request processing with request tracking
    • /api/v1/ - Queue disabled (legacy): Direct synchronous execution

  • Request queue system with endpoints: /executecommand-async, /status/<id>, /result/<id>, /queue/status

  • Automatic routing based on user's queue preference during service creation

  • V1 Concurrent Request Fix: Enhanced error handling to detect empty responses and return proper busy messages

Changes

  • Queue-enabled services default to v2 API with full async capabilities
  • Legacy direct execution maintains v1 compatibility with improved error messaging
  • Proper HTTP status codes (503) for busy/unavailable responses

@amangalampalli-ks
Implement API versioning for service mode based on queue enabling (#1560
20d8a59 
)

* Implement both v1 and v2 versions of service mode with request queue enable option

* Handle server busy response messages

* Update unit-tests

* Implement review comments - fix race condition, add validations, add return types.
@amangalampalli-ks amangalampalli-ks self-assigned this Aug 25, 2025
@amangalampalli-ks amangalampalli-ks marked this pull request as ready for review August 25, 2025 15:57
@craiglurey craiglurey merged commit 9b5bbec into release Aug 25, 2025
4 checks passed
@sk-keeper sk-keeper deleted the fix/service-mode-v1-v2 branch September 1, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craiglurey craiglurey craiglurey approved these changes

@sk-keeper sk-keeper Awaiting requested review from sk-keeper

Assignees

@amangalampalli-ks amangalampalli-ks

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amangalampalli-ks @craiglurey