Skip to content

Fixed IAM User rotation #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

Fixed IAM User rotation #1602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions keepercommander/commands/discoveryrotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,13 +555,14 @@ def config_iam_aad_user(_dag, target_record, target_iam_aad_config_uid):
[target_record.record_uid, target_record.title, not disabled, record_config_uid, record_resource_uid, schedule,
complexity])

# 6. Construct Request object
# 6. Construct Request object for IAM: empty resourceUid and noop=False
rq = router_pb2.RouterRecordRotationRequest()
if current_record_rotation:
rq.revision = current_record_rotation.get('revision', 0)
rq.recordUid = utils.base64_url_decode(target_record.record_uid)
rq.configurationUid = utils.base64_url_decode(record_config_uid)
rq.resourceUid = utils.base64_url_decode(record_resource_uid) if record_resource_uid else b''
rq.resourceUid = b'' # non-empty resourceUid sets is as General rotation
rq.noop = False # True sets it as NOOP
rq.schedule = json.dumps(record_schedule_data) if record_schedule_data else ''
rq.pwdComplexity = pwd_complexity_rule_list_encrypted
rq.disabled = disabled
Expand Down Expand Up @@ -1004,6 +1005,9 @@ def add_folders(sub_folder): # type: (BaseFolderNode) -> None

r_requests = [] # type: List[router_pb2.RouterRecordRotationRequest]

# Note: --folder, -fd FOLDER_NAME sets up General rotation
# use --schedule-only, -so to preserve individual setups (General, IAM, NOOP)
# use --iam-aad-config, -iac IAM_AAD_CONFIG_UID to convert to IAM User
for _record in pam_records:
tmp_dag = TunnelDAG(params, encrypted_session_token, encrypted_transmission_key, _record.record_uid)
if _record.record_type in ['pamMachine', 'pamDatabase', 'pamDirectory', 'pamRemoteBrowser']:
Expand All @@ -1019,6 +1023,7 @@ def add_folders(sub_folder): # type: (BaseFolderNode) -> None
' --resource is used to configure users found on a resource.'
' --iam-aad-config-uid is used to configure AWS IAM or Azure AD users')

# NB! --folder=UID without --iam-aad-config, or --schedule-only converts to General rotation
if iam_aad_config_uid:
config_iam_aad_user(tmp_dag, _record, iam_aad_config_uid)
else:
Expand Down