Skip to content

fix: Add accurate month logic to generateElapsedTimeText function #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix: Add accurate month logic to generateElapsedTimeText function #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/utils/commonUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,14 @@ export const generateElapsedTimeText = (timeString: string) => {
const minutes = Math.floor(seconds / 60);
const hours = Math.floor(minutes / 60);
const days = Math.floor(hours / 24);
const months = Math.floor(days / 30);
const years = Math.floor(days / 365);

if (millisecondsDiff < 60000) return 'Just now';
else if (minutes < 60) return minutes === 1 ? '1 minute ago' : `${minutes} minutes ago`;
else if (hours < 24) return hours === 1 ? '1 hour ago' : `${hours} hours ago`;
else if (days < 365) return days === 1 ? '1 day ago' : `${days} days ago`;
else if (days < 30) return days === 1 ? '1 day ago' : `${days} days ago`;
else if (months < 12) return months === 1 ? '1 month ago' : `${months} months ago`;
else return years === 1 ? '1 year ago' : `${years} years ago`;
};

Expand Down