Ab#74456 #37
Merged
Ab#74456 #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where ACM tags were incorrectly being sent during certificate renewal/replacement operations in the AWS ACM orchestrator. The fix ensures that tags are only applied when creating new certificates, not when renewing or replacing existing ones.
- Adds conditional check to prevent ACM tags from being sent when certificate ARN is provided (renewal/replace scenario)
- Updates README support section for clarity and accuracy
- Documents the bug fix in changelog for version 3.0.2
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| aws-acm-orchestrator/Jobs/Management.cs | Adds condition to prevent sending ACM tags during certificate renewal/replacement |
| README.md | Clarifies support information and improves wording |
| CHANGELOG.md | Documents the bug fix for version 3.0.2 |
|
|
||
| ## Support | ||
| The AWS Certificate Manager (ACM) Universal Orchestrator extension If you have a support issue, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com. | ||
| The AWS Certificate Manager (ACM) Universal Orchestrator extension is supported by Keyfactor. If you require support for any issues or have feature request, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com. |
There was a problem hiding this comment.
The sentence contains a grammatical error. It should be 'have a feature request' instead of 'have feature request'.
Suggested change
| The AWS Certificate Manager (ACM) Universal Orchestrator extension is supported by Keyfactor. If you require support for any issues or have feature request, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com. | |
| The AWS Certificate Manager (ACM) Universal Orchestrator extension is supported by Keyfactor. If you require support for any issues or have a feature request, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.