Store type merge ci fix #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge 1.8.4 to main
…mit to this repo's main. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
New Pull Request - all:main
There was a problem hiding this comment.
Pull Request Overview
This PR addresses CI/CD workflow issues related to branch naming for store type updates, along with configuration updates including new store types, corrected naming conventions, and standardized documentation strings.
Key changes:
- Enhanced branch naming logic to differentiate main branch updates from other branches
- Added Axis IP Camera store type configuration with authentication and certificate usage settings
- Corrected Bosch IP Camera naming from "BIPCamera" to "BoschIPCamera" for consistency
- Added UseShellCommands parameter to multiple Linux-based store configurations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/update-stores.yml | Updated branch naming strategy and improved console logging format |
| store_types.json | Added new store types, corrected names, standardized descriptions, and added UseShellCommands parameter |
| cmd/store_types.json | Mirrored changes from store_types.json for command-line tool configuration |
Comments suppressed due to low confidence (2)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "DependsOn": "", | ||
| "Type": "Bool", | ||
| "DefaultValue": "True", | ||
| "Description": "Recommended to be set to the default value of 'Y'. For a detailed explanation of this setting, please refer to [Use Shell Commands Setting](#use-shell-commands-setting)" |
There was a problem hiding this comment.
The description references a default value of 'Y', but the DefaultValue field is set to 'True'. This inconsistency could confuse users. Consider updating the description to reference 'True' instead of 'Y'.
Suggested change
| "Description": "Recommended to be set to the default value of 'Y'. For a detailed explanation of this setting, please refer to [Use Shell Commands Setting](#use-shell-commands-setting)" | |
| "Description": "Recommended to be set to the default value of 'True'. For a detailed explanation of this setting, please refer to [Use Shell Commands Setting](#use-shell-commands-setting)" |
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
spbsoluble
force-pushed
the
store_type_merge_ci_fix
branch
from
ab496dc to
fd8665b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.