Skip to content

Add printf format attribute and const qualifier to _s_out #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
assisted-by-ai wants to merge 3 commits into from
+23 −0
Closed

Add printf format attribute and const qualifier to _s_out #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcec037
Add __printf format attribute to _s_out for compile-time format checking
claude Apr 1, 2026
0b9f064
Add AGENTS.md documenting upstream PR for __printf annotation
claude Apr 10, 2026
b04d43f
Revert __printf annotation change to tirdad.c
claude Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Agent Instructions for tirdad

## Project Overview

tirdad is a Linux kernel module that randomizes TCP Initial Sequence Numbers
(ISN) for IPv4 and IPv6 to prevent CPU information leak side-channels. It uses
the kernel livepatch framework.

- **Upstream repo**: Kicksecure/tirdad
- **Language**: C (Linux kernel module)
- **Build**: `make` (requires kernel headers)
- **Packaging**: Debian/DKMS

## Known Upstream PR

There is an open upstream PR for adding `__printf` format attribute annotation
to `_s_out()`:

https://github.com/Kicksecure/tirdad/pull/3

The maintainer's position is that for a module this small (5 call sites, all
string literals with no format arguments), the change is too pedantic to
upstream. Do not re-propose this change.