-
Notifications
You must be signed in to change notification settings - Fork 4
Class dependencies #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Good feature, but, can you add some documentation that explain it? Maybe in the readme? I prefer single quote (') instead of double (") Could you use them? |
Will do.
I would rather not ecpecially not for doc strings -> https://www.python.org/dev/peps/pep-0008/#id25 And almost every tool uses double qoutes. I'm just a lazy bastard and use automation for formatting ;) See #17 |
|
Ok, let's use double. I started with single because I came from JS :) Anyway, I will think for automation formatting. |
KiraPC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@delijati Please add docs, also in class doc string, before merging it
| # add class dependencies | ||
| if dependencies: | ||
| for depends in dependencies[::-1]: | ||
| route.dependencies.insert(0, depends) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@delijati Does route.dependencies always exists?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@delijati I will move it at line 106, just to keep it separated from rewrite sign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Added some docs. I made the example on the frontpage copy pastable ;) |
Define dependencies class wide :) Sorry for the formatting changes.
Example: