Support explicit imports #44
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddevault
reviewed
Oct 27, 2017
assembler/assembler.c
Outdated
| /* TODO: Throw error if using explicit import */ | ||
| if (scas_runtime.options.explicit_import) { | ||
| bool imported=false; | ||
| list_t *imports=state->object->imports; |
ddevault
reviewed
Oct 27, 2017
assembler/directives.c
Outdated
| result = evaluate_expression(expression, state->equates, &error, &symbol); | ||
| } | ||
|
|
||
Member
|
Code looks good to me. |
pixelherodev
force-pushed
the
explicit-import
branch
from
dcd1063 to
28a1b4d
Compare
ddevault
reviewed
Oct 28, 2017
| for (int i = 0; i<state.object->unresolved->length; i++) { | ||
| unresolved_symbol_t *sym = (unresolved_symbol_t*)state.object->unresolved->items[i]; | ||
| bool imported = false; | ||
| for (int j = 0; j<state.object->imports->length; j++) { |
Member
There was a problem hiding this comment.
< operator needs spaces around it, too. Also >, <=, >=, and !=, and all arithmetic operators.
ddevault
reviewed
Oct 28, 2017
| scas_log(L_INFO, "Returning to file '%s'", (char *)stack_peek(state.file_name_stack)); | ||
| } else { | ||
| for (int i = 0; i<state.object->unresolved->length; i++) { | ||
| unresolved_symbol_t *sym = (unresolved_symbol_t*)state.object->unresolved->items[i]; |
Member
There was a problem hiding this comment.
Avoid lines >80 columns. Split it into two lines and indent the second line.
ddevault
reviewed
Oct 28, 2017
| scas_runtime.options.explicit_import = 1; | ||
| } | ||
| for (int i = 0; i < argc; ++i) { | ||
| scas_log(L_INFO, "Importing '%s'",argv[i]); |
Member
There was a problem hiding this comment.
This is too high of a log level for this message.
ddevault
reviewed
Oct 28, 2017
| case ERROR_DUPLICATE_SYMBOL: | ||
| return "Duplicate symbol '%s'"; | ||
| case ERROR_EXPLICIT_IMPORT: | ||
| return "Symbol '%s' not imported"; |
Member
There was a problem hiding this comment.
This should just reuse ERROR_UNKNOWN_SYMBOL
pixelherodev
pushed a commit
that referenced
this pull request
Oct 12, 2020
pixelherodev
pushed a commit
that referenced
this pull request
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.