fix: correctly obtain Git remote and parse it (#38)

* fix(vscode-github): correctly obtain Git remote and parse it

* fix(vscode-github): refactoring

* fix: github urls could contain colon

valid github urls could as well contain a colon to separate path (e.g.

git@github.com:knisterpeter/vscode-github.git)

Author: KnisterPeter

src/git.ts

@@ -1,15 +1,35 @@
 import * as execa from 'execa';
 
+import { parse } from 'url';
+
+/**
+ * Look in .git/config for a remote origin and parses it to get username and repository.
+ *
+ * @param {string} cwd The directory to find the .git/config file in.
+ * @return {Promise<string[]>} A tuple of username and repository (e.g. KnisterPeter/vscode-github)
+ * @throws Throws if the could not be parsed as a github url
+ */
 export async function getGitHubOwnerAndRepository(cwd: string): Promise<string[]> {
-  return execa('git', ['config', '--get-regexp', 'remote\\.origin\\.url'], {cwd})
-    .then(result => {
-      const match = result.stdout.match(
-        /^remote\.origin\.url (?:git@github\.com:|https:\/\/github.com\/)(.*?)\/(.*?)(?:.git)?$/);
-      if (!match) {
-        throw new Error('Not a github project?');
-      }
-      return [match[1], match[2]];
-    });
+  // as we expect this function to throw on non-Github repos we can chain
+  // whatever calls and they will thrown on non-correct remotes
+  const remote = (await execa('git', 'config --local --get remote.origin.url'.split(' '), {cwd})).stdout.trim();
+  if (!remote.length) {
+    throw new Error('Git remote is empty!');
+  }
+
+  // git protocol remotes, may be git@github:username/repo.git
+  // or git://github/user/repo.git, GITHUB domain name is not case-sensetive
+  if (remote.startsWith('git')) {
+    return remote.match(/^git(?:@|\:\/\/)github.com[\/:](.*?)\/(.*?)(?:.git)?$/i)!.slice(1, 3);
+  }
+
+  // it must be http or https based remote
+  const { hostname, pathname } = parse(remote);
+  // github.com domain name is not case-sensetive
+  if (!pathname || !hostname || !/^github\.com$/i.test(hostname)) {
+    throw new Error('Not a Github remote!');
+  }
+  return pathname.match(/\/(.*?)\/(.*?)(?:.git)?$/)!.slice(1, 3);
 }
 
 export async function getCurrentBranch(cwd: string): Promise<string|undefined> {