PHPCS cleanup and simplification in some cases.

* Shifted the Admin Bar CSS to add inline
* Hooked into `admin_bar_init` to simplify front-end and back-end CSS rendering.

Author: hellofromtonya

assets/css/admin-bar.html

@@ -19,5 +19,5 @@
 		'message_background_color'   => '#cb4b14',
 		'message_hover_color'        => '#1b202d',
 	],
-	'css_file' => _get_plugin_root_dir() . '/assets/css/admin-bar.html',
+	'css_file'     => _get_plugin_root_dir() . '/assets/css/admin-bar.php',
 ];

config/admin-bar.php

@@ -47,8 +47,7 @@
 		<properties>
 			<property name="prefixes" type="array">
 				<element value="KnowTheCode\DebugToolkit"/>
-				<element value="debugtoolkit_"/>
-                <element value="_genesis"/>
+				<element value="debug_toolkit"/>
 			</property>
 		</properties>
 	</rule>

phpcs.xml.dist

@@ -14,6 +14,7 @@
 
 /**
  * Class Admin_Bar
+ *
  * @package KnowTheCode\DebugToolkit
  */
 class Admin_Bar {
@@ -42,8 +43,7 @@ public function __construct( array $config ) {
 	public function init() {
 		add_filter( 'get_user_option_admin_color', [ $this, 'set_local_development_admin_color_scheme' ], 5 );
 		add_action( 'admin_bar_menu', [ $this, 'add_admin_bar_notice' ], 9999 );
-		add_action( 'admin_head', [ $this, 'render_admin_bar_css' ], 9999 );
-		add_action( 'wp_head', [ $this, 'render_admin_bar_css' ], 9999 );
+		add_action( 'admin_bar_init', [ $this, 'render_admin_bar_css' ], 9999 );
 	}
 
 	/**
@@ -93,12 +93,42 @@ public function render_admin_bar_css() {
 			return;
 		}
 
-		ob_start();
-
-		include $this->config['css_file'];
+		$css =
+			"
+			#wpadminbar {
+				background-color: %s !important;
+			}
+		
+			#wp-admin-bar-environment-notice {
+				display: none;
+			}
+		
+			#wpadminbar .ab-item,
+			#wpadminbar a.ab-item,
+			#wpadminbar > #wp-toolbar span.ab-label,
+			#wpadminbar > #wp-toolbar span.noticon,
+			.adminbar--environment-notice {
+				color: #fff;
+			}
+		
+			@media only screen and ( min-width: 800px ) {
+				#wp-admin-bar-environment-notice {
+					display: block;
+				}
+		
+				#wp-admin-bar-environment-notice .ab-item {
+					background-color: %s !important;
+				}
+		
+				#wp-admin-bar-environment-notice:hover .ab-item {
+					background-color: %s !important;
+					color: #fff;
+				}
+			}
+			";
 
-		$css_pattern = ob_get_clean();
+		$css = vsprintf( $css, $this->config['colors'] );
 
-		vprintf( $css_pattern, $this->config['colors'] );
+		wp_add_inline_style( 'admin-bar', $css );
 	}
 }

src/class-admin-bar.php

@@ -19,6 +19,7 @@
 
 /**
  * Class VarDumper_Helpers
+ *
  * @package KnowTheCode\DebugToolkit
  */
 class VarDumper_Helpers {
@@ -98,7 +99,7 @@ private static function set_styles() {
 	 * @param string $key Optional. Parameter's key to return.
 	 *
 	 * @return mixed
-	 * @throw  InvalidArgumentException If the key does not exist, an error is thrown.
+	 * @throws  InvalidArgumentException If the key does not exist, an error is thrown.
 	 */
 	private static function get_config( $key = '' ) {
 		if ( empty( static::$config ) ) {
@@ -109,18 +110,19 @@ private static function get_config( $key = '' ) {
 			 *
 			 * @param array Array of configuration parameters for the VarDump component.
 			 */
-			static::$config = apply_filters( 'debugtoolkit_set_html_dumper_config', (array) require _get_plugin_root_dir() . '/config/var-dumper.php' );
+			static::$config = apply_filters( 'debug_toolkit_set_html_dumper_config', (array) require _get_plugin_root_dir() . '/config/var-dumper.php' );
 		}
 
 		if ( empty( $key ) ) {
 			return static::$config;
 		}
 
 		if ( ! array_key_exists( $key, static::$config ) ) {
-			$message = __( 'The key [$s] does not exist in the config:', 'devtoolkit' );
+			$message = __( 'The key [$s] does not exist in the config:', 'debugtoolkit' );
 			$message = sprintf( $message, $key );
 			throw new InvalidArgumentException(
-				esc_html( $message . ': ' ) . print_r( static::$config, true )
+				esc_html( $message . ': ' ) .
+				print_r( static::$config, true ) // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_print_r
 			);
 		}
 

src/class-vardumper.php src/class-vardumper-helpers.phpsrc/class-vardumper.php renamed to src/class-vardumper-helpers.php

@@ -33,7 +33,7 @@ function _setup_plugin() {
  */
 function _setup_whoops() {
 	$whoops = new Run();
-	$whoops->pushHandler( new PrettyPageHandler );
+	$whoops->pushHandler( new PrettyPageHandler() );
 	$whoops->register();
 }
 

src/setup.php

@@ -17,7 +17,9 @@
 
 use KnowTheCode\DebugToolkit\VarDumper_Helpers;
 
-require_once __DIR__ . '/class-vardumper.php';
+require_once __DIR__ . '/class-vardumper-helpers.php';
+
+// phpcs:disable WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedFunctionFound -- Function names are intentational here.
 
 if ( ! function_exists( 'vdump' ) ) {
 	/**