Skip to content

Conversation

@fabianrbz
Copy link

@fabianrbz fabianrbz commented Jul 13, 2023

Now that the descriptions were merged into the schemas, we can pull them using the API.

Note:
I've used the kong/kong-gateway-dev latest docker image.
One thing to point out is that I've tried to validate the examples, and one of them is failing:

---------------------------------
| Plugin: application-registration
| Source: ./examples/application-registration/_3.4.x.yaml
| Response Code: 400
| Valid?: ❌
| name: schema violation
| fields: {"service"=>{"id"=>"missing primary key"}}
| code: 2
| message: schema violation (service.id: missing primary key)
---------------------------------

The example works for versions 3.3.x and 3.2.x (I haven't verified the rest).
It looks like the schema didn't change so I need to look into this a bit more.

Now that the descriptions were merged into the schemas, we can pull them
using the API.
@fabianrbz fabianrbz requested a review from lena-larionova July 13, 2023 09:07
@CLAassistant
Copy link

CLAassistant commented Jul 13, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Will have to update another time to add Redis descriptions as well, once I've got those ported over.

@fabianrbz fabianrbz merged commit 73ee3fa into Kong:main Jul 14, 2023
@fabianrbz fabianrbz deleted the pull-latest-schemas branch July 14, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants