Skip to content

Conversation

@fzhinkin
Copy link
Collaborator

As part of KLib support (#149) we need to bump the Kotlin version as the required API is only available starting from the 1.9.20.

@fzhinkin fzhinkin marked this pull request as ready for review January 30, 2024 15:18
testRuns["test"].executionTask.configure {
useJUnit()
}
attributes {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like functionalTests always use the same Kotlin version as the projects, so after updating to 1.9.22 we need to declare build variants here. Otherwise, the configuration won't succeed.

@fzhinkin fzhinkin requested a review from qwwdfsad January 30, 2024 15:19

internal fun BaseKotlinGradleTest.test(
gradleVersion: String = "7.4.2",
gradleVersion: String = "8.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we change the minimal supported Gradle version for BCV?
If so, worth noting it in README

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll double check it. But here the version was updated only to make tests work with 1.9.22 (as I mentioned elsewhere, that version leaks into functional tests and I don't know what to do with that).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we ever mentioned it explicitly, but the minimum supported Gradle version is 6.0 and after updating to Kotlin 1.9.22 the plugin still works with it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qwwdfsad qwwdfsad self-requested a review January 30, 2024 16:00
@fzhinkin fzhinkin merged commit 0bf5915 into develop Jan 31, 2024
@fzhinkin fzhinkin deleted the update-kotlin-to-1.9 branch January 31, 2024 11:15
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Oct 28, 2024
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 3, 2024
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants