Fixes pivot shortcuts to use PivotDsl
#1572
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
force-pushed
the
pivot-dsl
branch
from
08163a2 to
ef50adf
Compare
AndreiKingsley
requested changes
Nov 14, 2025
Collaborator
AndreiKingsley
left a comment
AndreiKingsley
left a comment
There was a problem hiding this comment.
Please, add
Select or express pivot columns using the [PivotDsl].
@include [PivotDslDocs]
in these overloads.
Also there's a mistake in columns argument description in 939th line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1548 by making all pivot shortcuts use
PivotDsl. I believe this will not cause issues asPivotDsl : ColumnsSelectionDsl, and all shortcuts simply callpivot {}.operation().